You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation of the mosdepth module on multiqc v1.16 states this:
Using "region" if exists, otherwise "global". Plotting 3 figures:
But this is not the case, and both global and region information are plotted. Either the selection of the "region" plots should be prioritized, hiding global information when region information is available (I would personally go for that), or either the documentation needs to be updated stating that both global and region information are always shown if available.
Also, the Mean Coverage information displayed on the main General Statistics table has changed from region to global too. This commit has changed obtaining that information from the global information line only of each *.mosdepth.summary.txt file, rather than being overwritten by the region information if available as it has always been until now.
This change is located in current multiqc v1.16 mosdepth.py file at line 131, that went from if line.startswith("total"):
to if line.startswith("total\t"):
In order to prioritize region information over global (which, again, I would personally go for that), that "\t" character should be removed.
The text was updated successfully, but these errors were encountered:
@jamigo, thank you for reporting this issue, it's a good catch. I agree that the global information should be hidden when the region information is available.
And good catch on checking "total" vs. "total_region" - I'll add a fix for that as well.
Really appreciate a detailed report and suggestions to fix!
Description of bug
The documentation of the mosdepth module on multiqc v1.16 states this:
But this is not the case, and both global and region information are plotted. Either the selection of the "region" plots should be prioritized, hiding global information when region information is available (I would personally go for that), or either the documentation needs to be updated stating that both global and region information are always shown if available.
Also, the Mean Coverage information displayed on the main General Statistics table has changed from region to global too. This commit has changed obtaining that information from the global information line only of each *.mosdepth.summary.txt file, rather than being overwritten by the region information if available as it has always been until now.
This change is located in current multiqc v1.16 mosdepth.py file at line 131, that went from
if line.startswith("total"):
to
if line.startswith("total\t"):
In order to prioritize region information over global (which, again, I would personally go for that), that "\t" character should be removed.
The text was updated successfully, but these errors were encountered: