Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosdepth module not prioritizing region over global information #2099

Closed
jamigo opened this issue Oct 3, 2023 · 1 comment · Fixed by #2106
Closed

mosdepth module not prioritizing region over global information #2099

jamigo opened this issue Oct 3, 2023 · 1 comment · Fixed by #2106
Labels
bug: module Bug in a MultiQC module

Comments

@jamigo
Copy link

jamigo commented Oct 3, 2023

Description of bug

The documentation of the mosdepth module on multiqc v1.16 states this:

Using "region" if exists, otherwise "global". Plotting 3 figures:

But this is not the case, and both global and region information are plotted. Either the selection of the "region" plots should be prioritized, hiding global information when region information is available (I would personally go for that), or either the documentation needs to be updated stating that both global and region information are always shown if available.

Also, the Mean Coverage information displayed on the main General Statistics table has changed from region to global too. This commit has changed obtaining that information from the global information line only of each *.mosdepth.summary.txt file, rather than being overwritten by the region information if available as it has always been until now.

This change is located in current multiqc v1.16 mosdepth.py file at line 131, that went from
if line.startswith("total"):
to
if line.startswith("total\t"):
In order to prioritize region information over global (which, again, I would personally go for that), that "\t" character should be removed.

@ewels ewels added the bug: module Bug in a MultiQC module label Oct 4, 2023
@vladsavelyev
Copy link
Member

@jamigo, thank you for reporting this issue, it's a good catch. I agree that the global information should be hidden when the region information is available.

And good catch on checking "total" vs. "total_region" - I'll add a fix for that as well.

Really appreciate a detailed report and suggestions to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants