Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global config for shared search #2152

Open
ewels opened this issue Oct 26, 2023 · 2 comments
Open

Add global config for shared search #2152

ewels opened this issue Oct 26, 2023 · 2 comments

Comments

@ewels
Copy link
Member

ewels commented Oct 26, 2023

We have shared: true in the search patterns for two use cases:

  • A generic filename, where there's a risk that the file could be incorrectly found and "consumed", being lost from other modules
  • Where the tool generates stdout, with the assumption that people may be concatenating log files.

I'm not sure that the second one happens much now, and it slows down the search quite a bit.

Idea is to remove these config options where the pattern looks specific, but add in a global option that effectively sets shared: true for all search patterns, in case there are users who are affected.

@vladsavelyev
Copy link
Member

@ewels - you added a lot of shared: true here: 902b18f
Most of which look unnecessary in terms of the first point. Do you think it makes sense to move those into a global flag?

@ewels
Copy link
Member Author

ewels commented Dec 19, 2023

Yup, exactly 👌🏻

That was 7 years ago, long enough for me to have my own weird log sharing stuff happening. I think it's ok to remove these now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants