Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastp: search pattern: look at content instead of file name #2213

Merged
merged 8 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- BCLConvert: fix mean quality, fix count-per-lane barplot ([#2197](https://github.com/ewels/MultiQC/pull/2197))
- Re-add `run()` into the `multiqc` namespace ([#2202](https://github.com/ewels/MultiQC/pull/2202))
- Add `.cram` to sample name cleaning defaults ([#2209](https://github.com/ewels/MultiQC/pull/2209))
- Fastp: search pattern: look at content instead of file name ([#2213](https://github.com/ewels/MultiQC/pull/2213))

### New Modules

Expand Down
2 changes: 1 addition & 1 deletion docs/modules/fastp.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: >
---

The Fastp module parses results generated by
[Fastp](https://github.com/OpenGene/fastp). Fastp can simply go through all fastq files in a folder and perform a series of quality control and filtering. Quality control and reporting are displayed both before and after filtering, allowing for a clear depiction of the consequences of the filtering process. Notably, the latter can be conducted on a variety of paramaters including quality scores, length, as well as the presence of adapters, polyG, or polyX tailing.
[Fastp](https://github.com/OpenGene/fastp). Fastp can simply go through all fastq files in a folder and perform a series of quality control and filtering. Quality control and reporting are displayed both before and after filtering, allowing for a clear depiction of the consequences of the filtering process. Notably, the latter can be conducted on a variety of parameters including quality scores, length, as well as the presence of adapters, polyG, or polyX tailing.

By default, the module generates the sample names based on the input FastQ file names in
the command line used by fastp. If you prefer, you can tell the module to use
Expand Down
4 changes: 3 additions & 1 deletion multiqc/utils/search_patterns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ dragen_fastqc:
eigenstratdatabasetools:
fn: "*_eigenstrat_coverage.json"
fastp:
fn: "*fastp.json"
fn: "*.json"
contents: '"read1_before_filtering": {'
num_lines: 100
fastq_screen:
fn: "*_screen.txt"
fastqc/data:
Expand Down