Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sheet Database #117

Merged
merged 8 commits into from
Apr 9, 2022
Merged

Update Sheet Database #117

merged 8 commits into from
Apr 9, 2022

Conversation

KyGost
Copy link
Member

@KyGost KyGost commented Apr 9, 2022

Resolves: #115
Assists: #62

@KyGost
Copy link
Member Author

KyGost commented Apr 9, 2022

Sheet deletion is failing for some reason (DELETE FROM); with Unimplemented

@KyGost
Copy link
Member Author

KyGost commented Apr 9, 2022

DROP TABLE didn't throw but also didn't work...

@codecov-commenter
Copy link

Codecov Report

Merging #117 (eb1f408) into main (748c249) will decrease coverage by 0.17%.
The diff coverage is 61.40%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   83.95%   83.78%   -0.18%     
==========================================
  Files         123      123              
  Lines        4033     4058      +25     
==========================================
+ Hits         3386     3400      +14     
- Misses        647      658      +11     
Impacted Files Coverage Δ
src/data/value/convert.rs 84.61% <0.00%> (-15.39%) ⬇️
src/data/value/mod.rs 61.79% <ø> (ø)
src/storages/sheet_storage/alter_table.rs 0.00% <0.00%> (ø)
src/storages/sheet_storage/auto_increment.rs 66.66% <33.33%> (-19.05%) ⬇️
src/data/value/cast.rs 75.33% <38.09%> (-2.93%) ⬇️
src/storages/sheet_storage/store_mut.rs 93.33% <75.00%> (-3.04%) ⬇️
src/storages/sheet_storage/mod.rs 80.00% <100.00%> (ø)
src/storages/sheet_storage/store.rs 80.39% <100.00%> (+1.66%) ⬆️
src/store/store_mut.rs 0.00% <0.00%> (ø)
src/store/auto_increment.rs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748c249...eb1f408. Read the comment docs.

@KyGost KyGost merged commit 0123714 into main Apr 9, 2022
@KyGost KyGost deleted the umya-update branch April 9, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sheet Storage: Delete Schema (needs umya-spreadsheet#47)
2 participants