Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RowIter #80

Merged
merged 6 commits into from
Apr 11, 2022
Merged

Remove RowIter #80

merged 6 commits into from
Apr 11, 2022

Conversation

KyGost
Copy link
Member

@KyGost KyGost commented Apr 4, 2022

Resolves: #125

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #80 (a79bdea) into main (d72f785) will increase coverage by 0.00%.
The diff coverage is 80.95%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   85.58%   85.59%           
=======================================
  Files         108      108           
  Lines        3671     3665    -6     
=======================================
- Hits         3142     3137    -5     
+ Misses        529      528    -1     
Impacted Files Coverage Δ
src/store/mod.rs 22.22% <0.00%> (ø)
src/executor/query/select/join/execute.rs 94.52% <50.00%> (-2.59%) ⬇️
src/data/index.rs 97.22% <100.00%> (+1.27%) ⬆️
src/executor/alter_row/delete.rs 90.90% <100.00%> (+2.02%) ⬆️
src/executor/alter_row/update.rs 93.54% <100.00%> (+1.24%) ⬆️
src/executor/alter_row/validate_unique.rs 84.72% <100.00%> (-0.21%) ⬇️
src/storages/csv_storage/store.rs 91.66% <100.00%> (-0.65%) ⬇️
src/storages/sled_storage/store.rs 86.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72f785...a79bdea. Read the comment docs.

@KyGost KyGost changed the title Custom Iterator Remove RowIter Apr 11, 2022
@KyGost KyGost changed the title Remove RowIter Remove RowIter Apr 11, 2022
@KyGost KyGost marked this pull request as ready for review April 11, 2022 03:58
@KyGost KyGost merged commit 9709878 into main Apr 11, 2022
@KyGost KyGost deleted the custom_iter branch April 11, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RowIter
2 participants