Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bitcoinj to latest version 0.13.2 #652

Closed
gary-rowe opened this issue Jul 9, 2015 · 5 comments
Closed

Update Bitcoinj to latest version 0.13.2 #652

gary-rowe opened this issue Jul 9, 2015 · 5 comments
Milestone

Comments

@gary-rowe
Copy link
Contributor

The latest version of Bitcoinj contains many fixes that we should include. In particular a fix for Tor connectivity (see #651) in Orchid 1.2.

We should use bitcoinj 0.13 when it is released

@gary-rowe gary-rowe added this to the Release 0.1.2 milestone Jul 9, 2015
@jim618 jim618 modified the milestones: Release 0.1.3, Release 0.1.2 Jul 9, 2015
@gary-rowe gary-rowe modified the milestones: Release 0.1.4, Release 0.1.3 Jul 20, 2015
@gary-rowe gary-rowe changed the title Update Bitcoinj to latest version Update Bitcoinj to latest version (fixes Tor) Jul 24, 2015
@jim618
Copy link
Contributor

jim618 commented Jul 31, 2015

Probably need to bump to use bitcoinj 0.13.2 when it comes out (in a week) as that is fixing some regressions in 0.13.1

@jim618 jim618 changed the title Update Bitcoinj to latest version (fixes Tor) Update Bitcoinj to latest version 0.13.2 Aug 10, 2015
@jim618
Copy link
Contributor

jim618 commented Aug 10, 2015

There is a new update to alice:
release-0.13.2-alice-0.1.3

There is a branch pushed and the artifacts are in the staging repo.

It does NOT increment the version of Tor though - it is a few bug fixes to Wallet/ Transaction etc.
thus the Tor connectivity problems we've been seeing are not addressed by this bump.

It still needs all the intermediate repos (multbit-commons) etc updated. I have jammed in the dependency into the MBHD develop pom.

MBHD appears to work exactly as before - done sync, repair wallet, send/ receive etc.

Awaiting review and closing.

@gary-rowe
Copy link
Contributor Author

@jim618 Can you build the latest MBHW as develop-SNAPSHOT and verify that it correctly generates expected addresses for a Trezor wallet, please? Ideally using a fresh wallet compared against, say, https://dcpos.github.io/bip39/.

There was an API change in Bitcoinj that moved the Utils.doubleHash() into Sha256Hash.hashTwice() which is used in the GetPublicKey of MultiBit Hardware. I'm confident it's OK due to my own testing, I just want independent verification.

@jim618
Copy link
Contributor

jim618 commented Aug 25, 2015

Successfuly tried out on a Mac:

  • empty and wipe existing Trezor wallet.
  • create new Trezor wallet
  • fund with 11 transactions from Classic
  • wait for confirmation on Trezor
  • check 2 receive addresses against https://dcpos.github.io/bip39/.
  • send 3 transactions out from Trezor
  • perform empty wallet on Trezor.

This all worked as expected.

Will install on the Windows 8 machine and try that out next

@jim618
Copy link
Contributor

jim618 commented Aug 25, 2015

I have performed a similar test on the Windows 8 machine and it all worked correctly.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants