Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popupwindow MultipleChoiceBox to show help button next to titl… #104

Merged
merged 1 commit into from
May 7, 2021

Conversation

pimerckx
Copy link
Contributor

@pimerckx pimerckx commented May 6, 2021

closes #103

Update to place help button on same line as title in case a title has been provided, but no header. When a header is provided, the help button will be placed next to the header.

I checked that the appearance of a Multiple choice popup is not affected when not providing a helpId.

New:
Screenshot 2021-05-06 at 11 20 30

Not affected:
Screenshot 2021-05-06 at 11 20 58
Screenshot 2021-05-06 at 11 21 14

…e when a title but no header has been defined. #103
@pimerckx pimerckx self-assigned this May 6, 2021
Copy link
Contributor

@MichaelVyverman MichaelVyverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pimerckx pimerckx merged commit 1f852b2 into master May 7, 2021
@pimerckx pimerckx deleted the feature/103/dont_put_help_button_on_separate_line branch May 7, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

put help button on same line as header text
2 participants