Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creating split track viewer without toolbox menu (#116) #117

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

basvandenberg
Copy link
Contributor

These changes enable adding a split track viewer without a toolbox menu (hamburger button at the top left). To reduce the risk of breaking existing functionality, and because this functionality is only required for the split track viewer at the moment, it is only implemented for the split track viewer, not for the regular track viewer.

Copy link
Contributor

@goranvinterhalter goranvinterhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you will make one small change I requested before merging.
LGTM

Panels/FrameTrackViewer.js Outdated Show resolved Hide resolved
Co-authored-by: Goran Vinterhalter <45198209+goranvinterhalter@users.noreply.github.com>
@basvandenberg basvandenberg merged commit e384e07 into master Aug 11, 2021
@basvandenberg basvandenberg deleted the feature/116/viewer_without_popup_menu branch August 11, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants