Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also allow :, notation when interpolating string for snippets. #121

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

pimerckx
Copy link
Contributor

Currently always format numbers as 'en-US' and not via the client locale's formatting when :, is part of the interpolation string.

formatting as en-US does more then only adding comma's, like automatically using a dot as decimal separator. This is however exactly what we want.

@pimerckx pimerckx self-assigned this Oct 20, 2021
Copy link
Contributor

@MichaelVyverman MichaelVyverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pimerckx pimerckx merged commit b561e1e into master Oct 20, 2021
@pimerckx pimerckx deleted the feature/handle_number_formatting_in_snippets branch October 20, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants