Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode html entities for filesaver #25 #26

Merged
merged 1 commit into from
Oct 19, 2018
Merged

decode html entities for filesaver #25 #26

merged 1 commit into from
Oct 19, 2018

Conversation

MichaelVyverman
Copy link
Contributor

No description provided.

michielvermeir
michielvermeir approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@michielvermeir michielvermeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michielvermeir michielvermeir merged commit 7c14fff into master Oct 19, 2018
@jeroencrappe
Copy link

Do we need to check now if we don't undo any changes that we implemented in light of XSS?

@MichaelVyverman
Copy link
Contributor Author

Tested it with the basic script tags injection and did not get any server->client injections.

@MichaelVyverman MichaelVyverman deleted the feature/25/decode branch January 21, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielvermeir michielvermeir michielvermeir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelVyverman @jeroencrappe @michielvermeir