Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Checkstyle & Rules. #2994

Merged
merged 23 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6a309f0
Update dtd reference in mv_checks.xml.
dumptruckman Sep 6, 2023
e04b0fa
Upgrade checkstyle to version 10.12.2.
dumptruckman Sep 6, 2023
ab2dd9d
Configure Javadoc checkstyle.
dumptruckman Sep 6, 2023
28edf86
Configure Annotation checkstyle.
dumptruckman Sep 6, 2023
f725723
Configure Block Checks checkstyle.
dumptruckman Sep 6, 2023
1d47473
Configure Class Design checkstyle.
dumptruckman Sep 6, 2023
c62c127
Configure Coding checkstyle.
dumptruckman Sep 6, 2023
086c3e8
Configure Imports checkstyle.
dumptruckman Sep 6, 2023
d7f2364
Configure Metrics checkstyle.
dumptruckman Sep 6, 2023
67f2f1f
Configure Miscellaneous checkstyle.
dumptruckman Sep 6, 2023
e8e8c4a
Configure Modifiers checkstyle.
dumptruckman Sep 6, 2023
073d13c
Configure Naming Conventions checkstyle.
dumptruckman Sep 6, 2023
405a033
Configure Size Violations checkstyle.
dumptruckman Sep 6, 2023
407dcb3
Configure Regexp checkstyle.
dumptruckman Sep 6, 2023
bc830ee
Configure Whitespace checkstyle.
dumptruckman Sep 6, 2023
dcbcca9
Remove extra check.
dumptruckman Sep 6, 2023
8b895d4
Add workflow for running and reporting checkstyle.
dumptruckman Sep 6, 2023
950fe12
Add reviewdog debug flag for checkstyle action.
dumptruckman Sep 6, 2023
49fcadf
Use the correct file extension for checkstyle config.
dumptruckman Sep 6, 2023
5b8984a
Test change that fails checkstyle.
dumptruckman Sep 6, 2023
87271aa
Revert "Test change that fails checkstyle."
dumptruckman Sep 6, 2023
d50e8c1
Remove checkstyle debug flag.
dumptruckman Sep 6, 2023
3198fcc
Fix job name in pr.checkstyle.yml.
dumptruckman Sep 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/generic.checkstyle.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: 'Generic: Checkstyle'

on:
workflow_call:

jobs:
checkstyle:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v3

- uses: dbelyaev/action-checkstyle@v0.8.4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
checkstyle_version: 10.12.2
checkstyle_config: ./config/mv_checks.xml
9 changes: 9 additions & 0 deletions .github/workflows/pr.checkstyle.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: 'PR: Checkstyle'

on:
pull_request:
types: [opened, synchronize]

jobs:
checkstyle:
uses: ./.github/workflows/generic.checkstyle.yml
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ processResources {


checkstyle {
toolVersion = '6.1.1'
toolVersion = '10.12.2'
configFile file('config/mv_checks.xml')
ignoreFailures = true
}
Expand Down