Tests assertions #379
Tests assertions #379
Conversation
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
|
|
||
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); | ||
| Assert.isNull(computedCoordinates[0].lat); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
| ); | ||
|
|
||
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); | ||
| Assert.isNull(computedCoordinates[0].lat); | ||
| Assert.isNull(computedCoordinates[0].lon); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
|
|
||
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); | ||
| Assert.areEqual(LATITUDE, computedCoordinates[0].lat); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); | ||
| Assert.areEqual(LATITUDE, computedCoordinates[0].lat); | ||
| Assert.areEqual(LONGITUDE, computedCoordinates[0].lon); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
| ); | ||
|
|
||
| // THEN | ||
| Assert.areEqual(1, computedCoordinates.size()); |
There was a problem hiding this comment.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
clayton-staging
bot
dismissed stale reviews from themself
This code review is obsolete
No description provided.