incomm #391
Open
incomm #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review not passed
This is the summary of issues introduced by this change:
| Policy name | Issues |
|---|---|
| Security (Orgs) | 0 |
| Test Custom Policy Conga | 0 |
| Flow Best Practices | 0 |
| Large Data Volumes | 1 |
| Naming Conventions | 0 |
| Salesforce Release Readiness | 0 |
| Documentation | 0 |
| Testing Best Practice | 0 |
| Clean Code | 0 |
| Error Handling | 0 |
| Unused Code | 0 |
| @@ -11,6 +11,10 @@ public class CandidateGradeController { | |||
| User currentUser = [SELECT Seniority__c FROM User where Id = :UserInfo.getUserId()]; | |||
| String temperature = ''; | |||
| Double commission = 0; | |||
|
|
|||
| for (int i = 0; i < 5; i++) { | |||
| Contact currentContact22 = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; | |||
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| @@ -11,6 +11,10 @@ public class CandidateGradeController { | |||
| User currentUser = [SELECT Seniority__c FROM User where Id = :UserInfo.getUserId()]; | |||
| String temperature = ''; | |||
| Double commission = 0; | |||
|
|
|||
| for (int i = 0; i < 7; i++) { | |||
| Contact currentContact22 = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; | |||
There was a problem hiding this comment.
Reliable: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.