Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove theme configs override #133

Merged
merged 2 commits into from
May 23, 2024
Merged

refactor: remove theme configs override #133

merged 2 commits into from
May 23, 2024

Conversation

sumitd94
Copy link
Contributor

@sumitd94 sumitd94 commented May 16, 2024

Description

  • Removed configs that overrides the theme
  • Added zustand store to update apiHost

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@sumitd94 sumitd94 requested a review from macintushar May 16, 2024 16:48
@sumitd94 sumitd94 self-assigned this May 16, 2024
@sumitd94 sumitd94 merged commit 67d02c0 into main May 23, 2024
2 checks passed
@sumitd94 sumitd94 deleted the refactor/ce-files branch May 23, 2024 15:58
suras pushed a commit to suras/multiwoven that referenced this pull request May 27, 2024
Signed-off-by: Sumit Dhanania <sumitdhanania94@gmail.com>
afthabvp pushed a commit that referenced this pull request Jun 13, 2024
afthabvp added a commit that referenced this pull request Jun 13, 2024
Co-authored-by: TivonB-AI2 <124182151+TivonB-AI2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants