Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerless if with not-condition ends render #2

Closed
rolandliwag opened this issue Apr 20, 2014 · 3 comments
Closed

Containerless if with not-condition ends render #2

rolandliwag opened this issue Apr 20, 2014 · 3 comments
Labels

Comments

@rolandliwag
Copy link
Collaborator

Here's an example:

<div>
<!-- if: !value -->
blah blah
<!-- /if -->

<p>This is after</p>
</div>

If you try to render that with value set to a non-falsy value, This is after will not be rendered.

@Munawwar
Copy link
Owner

Seems like the code always ignored the /if tag when "if" evaluates to false.
While thinking about how to fix this, I realized that it is easier to first determine all the containerless if,foreach blocks before starting to evaluate them.
So I refactored the code and fixed this issue in fb08069.

@Munawwar
Copy link
Owner

BTW I also fixed two bugs with ifnot binding (f782a87 and dadcb3f). You can use ifnot here if you wish.

@rolandliwag
Copy link
Collaborator Author

Ok, I'll check it out tomorrow. Welcome back btw.

On Saturday, April 26, 2014, Munawwar notifications@github.com wrote:

BTW I also fixed two bugs with ifnot binding (f782a87f782a87603and
dadcb3f dadcb3f6d23). You
can use ifnot here if you wish.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41469310
.

@Munawwar Munawwar added the bug label Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants