Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [feature]: noMetaSections #194

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Schnouki
Copy link
Contributor

@Schnouki Schnouki commented Nov 6, 2018

Instead of only hiding meta (date, reading time…) on pages, hide them for sections listed in a configurable array named noMetaSections. Defaults to ["page"] for backward compatibility.

This is useful if a site includes several types of sections. For instance I'm working on a portfolio section, and I don't want to include a date or reading time on these pages. This makes this behaviour possible and simple to achieve without overriding a partial from the theme.

@MunifTanjim
Copy link
Owner

MunifTanjim commented Nov 6, 2018

@Schnouki Cool feature! 👍

Would you mind changing the option name to hideEntryMeta?

Instead of only hiding meta (date, reading time…) on pages, hide them for
sections listed in a configurable array named `hideEntryMeta`. Just like
`hideEntryNavigation`, it can also be a boolean to hide meta for all sections.
Defaults to `["page"]` for backward compatibility.
@Schnouki
Copy link
Contributor Author

Schnouki commented Nov 7, 2018

@MunifTanjim Good idea, hideEntryMeta is a much better name, and more consistent with hideEntryNavigation.

To make it even more consistent I made it possible for this option to be a boolean instead.

@MunifTanjim MunifTanjim merged commit c144d6b into MunifTanjim:master Nov 7, 2018
@Schnouki Schnouki deleted the no-meta-sections branch November 7, 2018 15:17
@Schnouki Schnouki restored the no-meta-sections branch September 23, 2019 10:10
@Schnouki Schnouki deleted the no-meta-sections branch September 23, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants