Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popup): add method popup:set_layout(config) #127

Merged
merged 5 commits into from Jun 20, 2022

Conversation

MunifTanjim
Copy link
Owner

:set_layout replaces the following methods:

  • :set_position
  • :set_size

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #127 (49319c1) into main (13ae238) will increase coverage by 1.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.03%   90.93%   +1.90%     
==========================================
  Files          13       13              
  Lines        1386     1401      +15     
==========================================
+ Hits         1234     1274      +40     
+ Misses        152      127      -25     
Impacted Files Coverage Δ
lua/nui/popup/border.lua 76.79% <100.00%> (+0.86%) ⬆️
lua/nui/popup/init.lua 88.09% <100.00%> (+11.65%) ⬆️
lua/nui/utils/init.lua 98.01% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ae238...49319c1. Read the comment docs.

@MunifTanjim MunifTanjim force-pushed the feat-popup-set-layout branch 2 times, most recently from 6c80041 to 58453a2 Compare June 20, 2022 10:26
@MunifTanjim MunifTanjim force-pushed the feat-popup-set-layout branch 4 times, most recently from 18835eb to 87226e8 Compare June 20, 2022 10:54
@MunifTanjim MunifTanjim marked this pull request as ready for review June 20, 2022 10:59
@MunifTanjim MunifTanjim merged commit 0f590b7 into main Jun 20, 2022
@MunifTanjim MunifTanjim deleted the feat-popup-set-layout branch June 20, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant