Skip to content

Commit

Permalink
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
Browse files Browse the repository at this point in the history
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
  • Loading branch information
fanquake authored and Munkybooty committed Dec 15, 2021
1 parent 5eb8cfc commit 3b4c0e5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/validation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,8 @@ static bool AcceptToMemoryPoolWorker(const CChainParams& chainparams, CTxMemPool

// Do not work on transactions that are too small.
// A transaction with 1 empty scriptSig input and 1 P2PKH output has size of 85 bytes.
// Transactions smaller than this are not relayed to reduce unnecessary malloc overhead.
// Transactions smaller than this are not relayed to mitigate CVE-2017-12842 by not relaying
// 64-byte transactions.
if (::GetSerializeSize(tx, SER_NETWORK, PROTOCOL_VERSION) < MIN_STANDARD_TX_SIZE)
return state.DoS(0, false, REJECT_NONSTANDARD, "tx-size-small");

Expand Down

0 comments on commit 3b4c0e5

Please sign in to comment.