Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply toybox with AppManager #84

Closed
MuntashirAkon opened this issue Aug 28, 2020 · 9 comments
Closed

Supply toybox with AppManager #84

MuntashirAkon opened this issue Aug 28, 2020 · 9 comments
Labels
Feature New feature or request Priority: 1
Milestone

Comments

@MuntashirAkon
Copy link
Owner

AppManager use various commands which are not available on AP 23 or earlier and often some commands are not available either purposefully or due to vendor's mistake. I intend to use toybox to fix this issue. The benefit of toybox over busybox is that it also comes built-in with Android and is actively developed for this platform (and that it's developed by the same author who started busybox development). It's license (0BSD) is also compatible with GPL-3.0 license.

@IzzySoft Does F-Droid support the use of git submodules? I intend to add the project as a submodule to this project.

@IzzySoft
Copy link

Does F-Droid support the use of git submodules?

Yes, it does. Make sure the corresponding keyword is enabled in the metadata build block then (*.yml; manual MR required for the first version using it), e.g.:

Builds:
  - versionName: '3.0'
    versionCode: 30
    commit: v3.0
    subdir: app
    submodules: true
    gradle:
      - yes

(see the line with submodules: true which enables that feature)

PS: a pity that toybox is that limited… Do you know which Android version introduced it as being built-in?

@MuntashirAkon
Copy link
Owner Author

Do you know which Android version introduced it as being built-in?

API 24 (Android M)

@IzzySoft
Copy link

Thanks!

@MuntashirAkon
Copy link
Owner Author

Fixed via 78e25a5, f91a7f8, 98f935a and 60f6c0e

@MuntashirAkon MuntashirAkon added this to the v2.5.14 milestone Sep 6, 2020
@MuntashirAkon
Copy link
Owner Author

@IzzySoft Does F-Droid support split apks based on architecture? If so, does it require any MR or have version code rules like on Play Store? Toybox is compiled for multiple ABIs and it would be good if they can be distributed as split apks to reduce the file size.

@IzzySoft
Copy link

IzzySoft commented Sep 8, 2020

No idea. I'm no packager, so I'm the wrong person to ask that. AFAIK we have some multi-arch apps in the repo, but I don't know about support for split APKs. Better ask that eg at IRC.

@MuntashirAkon
Copy link
Owner Author

MuntashirAkon commented Sep 8, 2020

No idea. I'm no packager, so I'm the wrong person to ask that. AFAIK we have some multi-arch apps in the repo, but I don't know about support for split APKs. Better ask that eg at IRC.

It seems it doesn't support ABI splits (or any other splits): https://gitlab.com/fdroid/fdroidserver/-/issues/82. The only way is to use separate build flavours for each ABI. I think it's better to keep things as is until F-Droid team figures something out.

@MuntashirAkon
Copy link
Owner Author

@IzzySoft another question: is it enough to indicate NDK version in the build.gradle file? Or do I have to add it in F-Droid's build metadata as well? I'm using the latest NDK.

@IzzySoft
Copy link

IzzySoft commented Sep 9, 2020

May I quote myself:

No idea. I'm no packager, so I'm the wrong person to ask that.

It might be needed in the build recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Priority: 1
Projects
None yet
Development

No branches or pull requests

2 participants