-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark whole run as --todo
#186
Comments
I think I would recommend never to check external links in your build process, using the For the external lin check I would recommend to run it as a manual audit once in a while, not marking them as I haven't found good CI support for a concept of a warning that lets you continue the build, but collect all the warnings for a report that can be acted upon, so for now I think the manual audit is the way to go for external links to avoid getting your CI pipeline blocked |
thank you very much for your answer!! |
Since @khoivan88 brought that topic up in the 11ty Discord before, let me chime in :-) Alternatively to Although, knowing which page contained that link could be helpful if I want to fix it. |
@Ryuno-Ki In TAP semantics What @khoivan88 did with marking a test as I am definitely interested in finding a way where the external link check can be made useful as a CI task. But I think it would require some sort of report gathering and then having o pipe it to a different command that submits a webhook, or something along those lines. I feel that sort of work is a never-ending scope explosion, which doesn't overlap much with the core hyperlink functionality. If you want to change the output from hyperlink you can do so with a custom TAP reporter. This is one of the reasons I chose this format. You could use such a reporter as a filter to get just the Hyperlink does indeed report linking to a permanent redirect (301) as a failure |
Hi,
Thank you for this very useful library. I wanted to incorporate your tool into snowpack build on top of 11ty build. I was able to check all internal link successfully with your tool. Following your advice that all external links could also be check but not fail the build process, I'm struggling to mark all failed or skipped link for external as ok for the npm build process. Would you know how I can achieve this? Thank you very much!
Here is a portion of my
package.json
Right now, my trick is to use
//
as to mark all of external links so thehyperlink
check does not fail my npm run. However, I am just wondering if there is a better way?Thank you very much!
The text was updated successfully, but these errors were encountered: