Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Content-Type headers #138

Merged
merged 7 commits into from
Mar 30, 2018
Merged

Check Content-Type headers #138

merged 7 commits into from
Mar 30, 2018

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Mar 30, 2018

Complain if a HEAD request returns a Content-Type that contradicts what we expected based on the incoming relations, or if it is missing.

Also, test that we emit warnings during the regular population when a similar situation occurs.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.2%) to 89.575% when pulling 6a2f39b on feature/checkContentType into 6271418 on master.

@coveralls
Copy link

coveralls commented Mar 30, 2018

Coverage Status

Coverage increased (+1.3%) to 87.454% when pulling 0753bff on feature/checkContentType into f77e47a on master.

@papandreou papandreou added the WIP label Mar 30, 2018
papandreou and others added 3 commits March 30, 2018 16:02
* master:
  Separate external-check from external-redirect operation
  Refactor away logResult function and lodash
  Refactor away url module dependency
  Escape newlines in literal output from html. This avoids breaking yaml blocks

Conflicts:
  lib/index.js
@Munter Munter merged commit 55c028b into master Mar 30, 2018
@Munter Munter deleted the feature/checkContentType branch March 30, 2018 17:47
@Munter Munter added this to the v4 milestone Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants