Fix problem with failing fragment check on non-loaded external html assets #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be a performance regression. I'm testing out what happens if I immediately unload the asset before returning when hitting https://github.com/Munter/hyperlink/pull/147/files#diff-6d186b954a58d5bb740f73d84fe39073R484 |
|
Ok, seems I had a whole bunch of network timeouts, probably due to local conditions. Also possibly from loading the extra external assets. I'm finding true positives on the external fragment checks now 👯♂️ |
papandreou
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
Looks good!
It would help my efforts over at #143 if the test could also assert that outgoing relations from
https://example2.com/foo.html aren't followed.
|
I'll extend the test with a few outgoing extras without allowing the network traffic |
…was loaded due to incoming fragment identifier relations
Munter
added a commit
that referenced
this pull request
Jul 23, 2018
…hough the asset would normally not be populated. Same as #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in gitter, anchors (and similar) to external assets, which contain fragment identifiers, failed the fragment-check test because the external asset was never loaded.
id's before stopping the further processing