Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/handle GitHub readme fragments #159

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

Munter
Copy link
Owner

@Munter Munter commented Aug 13, 2019

Github does a weird rewrite of heading fragments where they have a slugified link to a fragment that represents the user content, but the corresponding id-attribute has a prepended user-content-, which they then figure out how to navigate to with javascript.

<a id="user-content-6-test262-status" class="anchor" aria-hidden="true" href="#6-test262-status">

This caused problems with hyperlinks fragment check. Hyperlink now re-tries checking the fragment with the prepended string if the content is on github.com

@Munter Munter merged commit 66bc6ba into master Aug 13, 2019
@Munter Munter deleted the feature/handle-github-readme-fragments branch August 13, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant