Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging that pyftsubset is missing despite not needing it #88

Closed
Munter opened this issue May 23, 2020 · 0 comments
Closed

Logging that pyftsubset is missing despite not needing it #88

Munter opened this issue May 23, 2020 · 0 comments

Comments

@Munter
Copy link
Owner

Munter commented May 23, 2020

When the fonttools package is not installed I get this log:


Running subfont version 4.2.2
 ✔ 0.000 secs: logEvents
 ✔ 0.054 secs: loadAssets
 ✔ 0.341 secs: populate
 ✔ 0.000 secs: checkIncompatibleTypes
 ✔ 0.001 secs: populate
/bin/sh: pyftsubset: command not found
 ✔ 0.020 secs: compressJavaScript
 ✔ 0.004 secs: writeAssetsToDisc
dist/index.html: 1 font (1 variant) in use, 59.2 kB total. Created subsets: 0 B total
  Tangerine:
    700 : 9/212 codepoints used, no subset font created
HTML/JS/CSS size increase: 888 B
Total savings: -888 B
Output written to file:///Users/pbm/git/plugin-subfont-demo/dist/

Content of index.html

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Netlify-plugin-subfont Demo</title>

  <link href="https://fonts.googleapis.com/css?family=Tangerine:700" rel="stylesheet">
  <link rel="stylesheet" href="style.css">
</head>

<body>

  <div>
    <h1>Hello World!</h1>
  </div>

</body>

</html>

There are no references to local font files

Expected: No log message about pyftsubset when it is not needed
@Munter Munter closed this as completed in 442214c May 23, 2020
papandreou added a commit that referenced this issue Jun 1, 2020
@papandreou
Merge branch 'master' into feature/harfbuzz
5daf290 
* master: (28 commits)
  5.0.2
  Make it less messy by delaying the detaching of those relations
  Fix Munter/netlify-plugin-subfont#32
  5.0.1
  Update to font-snapper 1.0.2
  Only distribute relevant files in npm package
  5.0.0
  Update to prettier 2 and reformat all files
  Update yargs to 15.3.1
  Update sinon to 9.0.2
  Update to nyc 15
  Update to puppeteer 3.1.0
  Update engine node engine requirement to >=10
  Update mocha to 7.2.0
  Update eslint and plugins
  Update to font-tracer 2 and deprecate node 8 support. SEMVER-MAJOR
  Don't break when an unused variant points at a non-existent file
  Update asetgraph to 6.0.7
  Fix missing font size difference calculation in console output. Fixes #89
  Silence console output from testing for pyftsubset when pyftsubset is missing. Fixes #88
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Munter