Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --inline-fonts switch, always keep the fonts inline when only one format is requested #125

Closed

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Aug 8, 2020

Fixes #10.

As suggested in #10 (comment)

  • Consider also making it a prerequisite that the given font is used on every page.

Just keep the subsets inline when only one format is to be supported.
#10 (comment)
@papandreou papandreou changed the title Remove the --inline-fonts, always keep the fonts inline when only one format is requested Remove the --inline-fonts switch, always keep the fonts inline when only one format is requested Aug 8, 2020
@papandreou papandreou requested a review from Munter August 8, 2020 13:47
@coveralls
Copy link

coveralls commented Aug 8, 2020

Pull Request Test Coverage Report for Build 579

  • 42 of 43 (97.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 90.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/parseCommandLineOptions.js 1 2 50.0%
Totals Coverage Status
Change from base Build 560: -0.03%
Covered Lines: 1153
Relevant Lines: 1229

💛 - Coveralls

papandreou and others added 6 commits August 13, 2020 08:49
* feature/removeSubsetPerPage: (31 commits)
  Update fontverter to ^1.0.1
  Make the reference image assertions more flexible, fix error handling
  Switch to the subset-font package
  Use the split-out fontverter module for sniffing and converting font buffers
  Fix `--obfuscate-names` argument
  5.3.0
  prettier
  Don't exercise hrefType:relative in the reference image tests
  Add the new switch to the README
  Expose --relative-urls option
  subsetFonts: Support hrefType option instead of hardcoding rootRelative
  Update assetgraph to ^6.5.0
  5.2.5
  Fix lint
  Simplify test case
  Rewrite JavaScript-based preload polyfill to fix #131
  5.2.4
  Use the font-family library to parse font-family property in postcss ast
  5.2.3
  Fix #130
  ...
@papandreou
Copy link
Collaborator Author

papandreou commented Apr 18, 2021

Landed in a85fc9c, released in 6.0.0

@papandreou papandreou closed this Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants