Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --relative-urls switch that makes subfont issue relative urls instead of root-relative ones #136

Merged
merged 6 commits into from Jan 25, 2021
Merged

Implement --relative-urls switch that makes subfont issue relative urls instead of root-relative ones #136

merged 6 commits into from Jan 25, 2021

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Jan 24, 2021 •
edited

Fixes #135

@papandreou papandreou self-assigned this Jan 24, 2021
@papandreou papandreou mentioned this pull request Jan 24, 2021
Closed
@papandreou
Don't exercise hrefType:relative in the reference image tests
d992cd3 
... to avoid "Bus error" crash, probably caused by exercising
the headless browser too much?
@papandreou
prettier
bf2c1fc
@coveralls
Copy link

coveralls commented Jan 24, 2021 •
edited

Pull Request Test Coverage Report for Build 604

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 90.432%
Totals Coverage Status
Change from base Build 597: -0.03%
Covered Lines: 1163
Relevant Lines: 1236
💛 - Coveralls

@thewilkybarkid
Copy link

Just tried this out and seems to work well!

@papandreou papandreou merged commit 41f8f79 into master Jan 25, 2021
@papandreou papandreou deleted the feature/relativeUrls branch January 25, 2021 23:21
@papandreou
Copy link
Collaborator Author

Released in 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating relative paths
3 participants
@papandreou @coveralls @thewilkybarkid