Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --no-recursive the default #28

Merged
merged 1 commit into from Oct 21, 2019
Merged

Conversation

papandreou
Copy link
Collaborator

There's a bit of evidence that --recursive is causing confusion and is hard to control:

We've previously talked about defaulting to non-recursive mode when we do the next major release. I'm leaving this here so we remember :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.286%

Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 21
Relevant Lines: 28

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 26, 2018

Pull Request Test Coverage Report for Build 176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 87.862%

Files with Coverage Reduction New Missed Lines %
lib/subfont.js 1 71.69%
Totals Coverage Status
Change from base Build 174: 0.0%
Covered Lines: 1762
Relevant Lines: 1908

💛 - Coveralls

@Munter
Copy link
Owner

Munter commented May 28, 2018

I'm on board with this. Not entirely sure when we should do a major version increase

@papandreou papandreou merged commit 3b203cb into master Oct 21, 2019
@papandreou papandreou deleted the feature/nonRecursiveByDefault branch October 21, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants