Ilc soft2.3.1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import getoutput from the appropriate place in util.py. This has changed locations between python2 and python3 and would ideally be replaced by a more modern check_output approach, but it is used so widely throughout that it is easier for now to just do it this way. - Use urrlib and fallback to urllib2 if necessary - Remove blanket imports in util and rather import them in the few places where it is actually necessary
The download path in the release tarball points to a no longer existing url. In the patch branch on github this has been fixed.
Some of the packages have cmake configurations that break starting with 3.17 if we want to build documentation. As a workaround we disable them for now until all these packages are fixed.
Not as easily possible for me to just merge PRs there
DESY SVN server has been decomissioned and some test beam packages have not yet been migrated to gitlab repositories. For now, disabling these packages for HEAD and v02-03 releases.
Starting with pytest 7.2.0(?) py.test.raises only works if py is also installed. Given pytest-dev/py#288 it is probably easiest to just use pytest directly if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Synchronize code with official release v02-03-01
Added a new component to install detector-simulation
ENDRELEASENOTES