New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement coupon list, add, remove & fix nulled package IDs #4

Merged

Muqsit merged 3 commits into Muqsit:master from CortexPE:patch-1

Dec 6, 2020

CortexPE commented Dec 6, 2020 •

edited

Loading

Changes:

implements listing, adding and removal of coupons
created .gitignore file
fixed execution of commands with null package_ids

Suggestions for future reference / work:

implement other coupon fields such as basket type and application rule
(probably) a form UI to aid creation of coupons and allow all the options to be utilized
infinite sub-commands for syntax like /tebex coupon <list|add|remove> (or at least allow subcommands with spaces)
add a limit to the discount value (if there is)

CortexPE added 3 commits

December 7, 2020 00:54


          initial PR commit

6465f7a


          fix formatting

9c8a9b9


          implement player username check

a21bc37

Muqsit merged commit 01d568e into Muqsit:master

HomeTreeBE mentioned this pull request

Startup Error #20

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment