Updates for 4.0 #15
Merged
Updates for 4.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several API changes had broken this. It works now.
Muqsit
reviewed
Nov 3, 2020
src/muqsit/vanillagenerator/generator/biomegrid/RiverMapLayer.php
Outdated
Show resolved
Hide resolved
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API has changed and this plugin isn't working on the latest pmmp master branch. This fixes the plugin so it will run, however I added comments where the "fix" isn't faithful to the original code, because I can't seem to get an instance of the ChunkManager in the constructor.