Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vimeo videos #575

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisMBarr
Copy link

Now videos from Vimeo.com can be added to a gallery just like YouTube by simply provide the video ID from the URL. For example this video: https://vimeo.com/124139626 is embedded like so:

{
  type: 'vimeo',
  autoplay: false,
  src: '124139626'
} as VimeoItemData,

Here's a screen recording of that Vimeo video working on the demo page.

vimeo-demo

Searching through old issues, this addresses additional concerns already addressed by #22, and might possibly address #539

The only thing not covered by this PR is updating all the wiki pages that mention youtube to also have mentions and code examples of Vimeo as well.

# Conflicts:
#	projects/ng-gallery-demo/src/app/pages/templates-example/templates-example.component.html
#	projects/ng-gallery/src/lib/components/gallery-item.component.ts
#	projects/ng-gallery/src/lib/components/gallery.component.ts
#	projects/ng-gallery/src/lib/components/templates/items.model.ts
@ChrisMBarr
Copy link
Author

I have resolved the merge issues since the v11 update, and I've tested this, and it's still working just fine.

Some logic around fetching a Vimeo thumbnail got a lot simpler than before, I opened an issue over there and it was resolved. For reference: ThatGuySam/vumbnail#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant