-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This repo not support pnpm #272
Comments
its |
That's a typo, but the problem remains |
I don't use pnpm, shouldn't it work like yarn? or I have to publish the package to pnpm? |
@MurhafSousli I think the problem is with Possible solution is installing directly to project: |
@MurhafSousli second option: add to .npmrc: |
@MurhafSousli so the idea is to make ngx-highlightjs works like solid package. Library should work like example: coreLibraryLoader: () => import('highlight.js/lib/core'),
languages: {
css: () => import('highlight.js/lib/languages/css'),
scss: () => import('highlight.js/lib/languages/scss'),
typescript: () => import('highlight.js/lib/languages/typescript'),
xml: () => import('highlight.js/lib/languages/xml'),
}, should be replaced with: coreLibraryLoader: () => import('ngx-highlightjs/highlight-lib'),
languages: {
css: () => import('ngx-highlightjs/languages/css'),
scss: () => import('ngx-highlightjs/languages/scss'),
typescript: () => import('ngx-highlightjs/languages/typescript'),
xml: () => import('ngx-highlightjs/languages/xml'),
}, |
This is a dependency, how can you receive updates and fixes from the main package then? |
@MurhafSousli So, for libraries there are 2 approaches:
|
I am afraid this is out of the scope for this project. This is just a wrapper package of |
Reproduction
Expected Behavior
run project
Actual Behavior
Environment
The text was updated successfully, but these errors were encountered: