Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Old Twitter Logo Update | 'X' #657

Closed
yuvrajsingh-kiwi opened this issue Jan 11, 2024 · 2 comments · Fixed by #665
Closed

Required Old Twitter Logo Update | 'X' #657

yuvrajsingh-kiwi opened this issue Jan 11, 2024 · 2 comments · Fixed by #665

Comments

@yuvrajsingh-kiwi
Copy link

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/ngx-sharebuttons

Steps to reproduce:

  1. Just check the logo of the Twitter Share Button

Expected Behavior

What behavior were you expecting to see?
New Logo Of Twitter 'X'

Actual Behavior

What behavior did you actually see?
Old Logo Of Twitter Button

Environment

  • Angular: 14
  • ngx-sharebuttons: 13
  • Browser(s): Chrome Latest
  • Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu
@AshotAleqsanyan96
Copy link

@yuvrajsingh-kiwi please check #650 they already have a PR, we are also waiting for this change.

@MurhafSousli
Copy link
Owner

MurhafSousli commented Jan 11, 2024

I will make the change but it may take sometime, but you don't need to wait! you can change the icon from the global options like so:

import { faXTwitter } from '@fortawesome/free-brands-svg-icons';
import { FaIconLibrary, } from '@fortawesome/angular-fontawesome';

@NgModule({
  imports: [
    ShareButtonsModule.withConfig({
      prop: {
        twitter: {
          icon: ['fab', 'x-twitter'],
          color: '#1E3050',
        }
      }
    })
  ],
})
export class AppModule {
  constructor(iconLibrary: FaIconLibrary) {
    iconLibrary.addIcons(faXTwitter);
  }
}

Here is a stackblitz: https://stackblitz.com/edit/ngx-sharebuttons-6hfmg3?file=src%2Fapp%2Fapp.module.ts

@MurhafSousli MurhafSousli linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants