Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add or replace twitter option for X #650

Closed
colorpicker-blue opened this issue Sep 4, 2023 · 5 comments · Fixed by #665
Closed

add or replace twitter option for X #650

colorpicker-blue opened this issue Sep 4, 2023 · 5 comments · Fixed by #665

Comments

@colorpicker-blue
Copy link

Feature Description

Twitter changed its brand. And the buttons should reflect this. Maybe it is too soon to remove the old one, but the addition of the new one should be a priority.

@MurhafSousli
Copy link
Owner

Yea, meanwhile you can override the icon, color and text from the global options

@Tweniee
Copy link

Tweniee commented Nov 24, 2023

@MurhafSousli can this be assigned to me

@MurhafSousli
Copy link
Owner

Feel free to submit a PR

Tweniee added a commit to Tweniee/ngx-sharebuttons that referenced this issue Nov 24, 2023
@Tweniee
Copy link

Tweniee commented Nov 24, 2023

I understand it's a minor point, but noting it for future reference. We should address the issue at FortAwesome/angular-fontawesome#411 and ensure that we are using the recommended version of the Font Awesome package, which is "6.4.2.

@MurhafSousli
Copy link
Owner

I understand it's a minor point, but noting it for future reference. We should address the issue at FortAwesome/angular-fontawesome#411 and ensure that we are using the recommended version of the Font Awesome package, which is "6.4.2.

Could you help with this?

@MurhafSousli MurhafSousli linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants