Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zip dependency to fix GCC14 build error #759

Merged
merged 1 commit into from
May 21, 2024

Conversation

AHSauge
Copy link
Contributor

@AHSauge AHSauge commented May 11, 2024

The zip submodule is built with -Wextra -Werror. At the very least with GCC14, this results in an error raised by calloc-transposed-args due to a call to calloc where the arguments are swapped around. I've fixed this upstream, and this is pulling the update in. At the time of writing, this means jumping to latest master, involving a jump from 0.2.x to 0.3.x. The minor bump seems to be due to the addition of some new functions.

It should be noted that I'm unable to successfully run ctest since I end up with

The following tests FAILED:
         17 - TreeView (Failed)
         18 - Submodule (Subprocess aborted)
         23 - fileContextMenu (Failed)

This is potentially connected with #546, but in my case I'm just trying to build it locally on my Fedora 40 installation. Additionally, test 17 (but not 18 or 23) fails on my Fedora 38 virtual machine both before and after updating this dependency.

Merge request created anyway since there's clearly a need to either update the zip dependency, or build with different settings for GCC14.

Change needed since zip contained a call to calloc where the argument
order was reversed. This results in calloc-transposed-args being raised.
@Murmele
Copy link
Owner

Murmele commented May 15, 2024

Can you delete all zip files and adding the zip repository as submodule?
https://github.com/richgel999/miniz

@AHSauge
Copy link
Contributor Author

AHSauge commented May 15, 2024

Can you delete all zip files and adding the zip repository as submodule? https://github.com/richgel999/miniz

Sorry, I'm a bit confused here now. This is updating the existing zip submodule to point to latest (right now) master in https://github.com/kuba--/zip, so from what I can tell there's no files added or removed here, just the submodule reference is updated. GitHub does make it look like there's files change though, but it's just the diff between the previous and new commit used from the submodule.

Maybe there's a misunderstanding here somewhere?

@Murmele
Copy link
Owner

Murmele commented May 15, 2024

Can you delete all zip files and adding the zip repository as submodule? https://github.com/richgel999/miniz

Sorry, I'm a bit confused here now. This is updating the existing zip submodule to point to latest (right now) master in https://github.com/kuba--/zip, so from what I can tell there's no files added or removed here, just the submodule reference is updated. GitHub does make it look like there's files change though, but it's just the diff between the previous and new commit used from the submodule.

Maybe there's a misunderstanding here somewhere?

Ah thanks for the hint. It was a missubderstanding on my side :)

@alerque
Copy link
Contributor

alerque commented May 21, 2024

Does this fix #766? If so can merging and releasing a minor patch release be made a priority so distro packaging has any chance of being possible?

@AHSauge
Copy link
Contributor Author

AHSauge commented May 21, 2024

Does this fix #766? If so can merging and releasing a minor patch release be made a priority so distro packaging has any chance of being possible?

It indeed fixes the error in #766.

I'll add that this builds and passes all tests on Arch Linux, at least if done in a chroot environment.

@Murmele Murmele merged commit 025f55c into Murmele:master May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants