Skip to content

Commit

Permalink
Remove Dead Code
Browse files Browse the repository at this point in the history
- Removes unused Tabs::NamesHelper methods
- See generally, e.g, Martin _Clean Code_; Fowler, _Tidy First?_.
- Turns CI checks completely green, improves Coverage. See https://coveralls.io/builds/65195848/source?filename=app%2Fhelpers%2Ftabs%2Fnames_helper.rb
  • Loading branch information
JoeCohen committed Jan 20, 2024
1 parent c136b4b commit 59e6f32
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions app/helpers/tabs/names_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -101,24 +101,7 @@ def mycobank_basic_search_tab
{ class: tab_id(__method__.to_s), target: :_blank, rel: :noopener }]
end

def name_correct_spelling_tab(name)
[name.correct_spelling.display_name.l,
add_query_param(name_path(name.correct_spelling_id)),
{ class: tab_id(__method__.to_s) }]
end

def show_name_tab(name)
[name.display_name.l, add_query_param(name_path(name.id)),
{ class: tab_id(__method__.to_s) }]
end

# lifeform tabs:
def propagate_lifeform_form_tab(name)
[:show_name_propagate_lifeform.t,
add_query_param(propagate_name_lifeform_form_path(name.id)),
{ class: tab_id(__method__.to_s) }]
end

def edit_name_lifeform_tab(name)
[:EDIT.l, add_query_param(edit_name_lifeform_path(name.id)),
{ class: tab_id(__method__.to_s), icon: :edit }]
Expand Down

0 comments on commit 59e6f32

Please sign in to comment.