Merge pull request #1856 from MushroomObserver/nimmo-add-target-index…

…-to-comments Add "login" index to Users table
MushroomObserver · Feb 10, 2024 · f27959e · f27959e
2 parents 83b0061 + c59e48e
commit f27959e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/db/migrate/20240126081715_add_login_index_to_users.rb b/db/migrate/20240126081715_add_login_index_to_users.rb
@@ -0,0 +1,9 @@
+class AddLoginIndexToUsers < ActiveRecord::Migration[7.1]
+  def up
+    add_index :users, :login, name: :login_index, if_not_exists: true
+  end
+
+  def down
+    remove_index :users, :login_id, name: :login_index
+  end
+end
diff --git a/test/models/description_test.rb b/test/models/description_test.rb
@@ -225,6 +225,7 @@ def test_groups
     assert_equal([rolf], desc.admins)
     assert_equal([rolf.id], desc.admin_ids)
     assert_equal(User.all, desc.writers)
+    # Must order on :id because of new table index on `login`
     assert_equal(User.order(:id).pluck(:id), desc.writer_ids)
     assert_equal(User.all, desc.readers)
     assert_equal(User.order(:id).pluck(:id), desc.reader_ids)