NamingConsensus
#1759
Merged
NamingConsensus
#1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are aliases of Observation methods, but they are guaranteed to set off N+1s if called from a NamingParams instance. They need to be called on the obs already instantiated in the controller. Reorder namings_controller fragmented methods Uncomment obs methods in naming_consensus
In NamingConsensus
Try reloading obs in NamingConsensus#calc_consensus
Delete naming_params class
Have not done the same for naming vote methods Use consensus in templates - namings table and matrix box (! for `what`)
Shorten call to NamingConsensus
Also bullet Naming.log_destruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PORO addressing #1722
This PR moves and centralizes all code that handles naming and voting on observations, or determining the current state of naming/voting for the front end.
It loads an observation's namings and votes into a new
NamingConsensusPORO in order to isolate the calculations involved in determining the observation's "consensus" naming and safeguard against any unintentional db loads whenever the namings or votes change or are calculated. Current form updates do something like 3*N+1 db loads per update, which causes a very noticeable slowdown — something like 10s on my machine/connection. Even displaying a show_obs page executes many duplicate expensive db loads.This covers pretty central functionality to MO, and although I don't expect anyone will review it, I hope everyone will.
Many thanks to Jason for inspiration and guidance through the whole process.
Notes:
Deletes
NamingParamsclass — moves all methods either back intoNamingsController, the only place they're used, or theNamingConsensusPORO to reduce indirection and duplication.Moves all voting methods out of the
NamingandObservationclasses, intoNamingConsensus.