Delete bulk editor vestiges #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletes the following things that refer to bulk name editor: - Code (all in ApplicationController) - Translation strings - Comments
- Add missing translation string and update its name
VSCode keeps demanding this change, even after I delete it.
- Rename method to describe actual intent - Move pre-method comment to appropriate location - Refactor to remove conditional
|
The following CI failure seems like a sytem test timing issue. (I can't replicate it locally.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at https://groups.google.com/g/mo-developers/c/C6r_km5n1G4.