Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Observation blank Scientific Name #1797

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Create Observation blank Scientific Name #1797

merged 5 commits into from
Jan 13, 2024

Commits on Jan 10, 2024

  1. Add test exposing bug

    @JoeCohen
    JoeCohen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    444f44d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Augment tests 

    - Add test exposing bug when proposing blank name
- Additional assertion for creating Obs with blank Scientific Name
- Add messages to assertions
    @JoeCohen
    JoeCohen committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8483122 View commit details
    Browse the repository at this point in the history

  2. Fix bug in creating Observation 

    - Gets rid of spurious, incomplete flash when user leaves Scientific Name blank
    @JoeCohen
    JoeCohen committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    94d82c4 View commit details
    Browse the repository at this point in the history

  3. Revert test of blank proposed name 

    I will handle that in a separate branch
    @JoeCohen
    JoeCohen committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d00ad52 View commit details
    Browse the repository at this point in the history

  4. Rubcopping 

    - Fixes ABC offense
- Deletes stray commented out code
    @JoeCohen
    JoeCohen committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8da9f60 View commit details
    Browse the repository at this point in the history