Proposed Name blank flash #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm changing my approach to solving the underlying problem. Instead of adding a message below: Add a flash error that's complete without additional explanation. Adding a message below is too convoluted for me to figure out.
If the User left the Scientific Name blank, flash a simple error message.
- Changes their order - Removes redundant assertion - Removes outdated comment
- inline cop disable/enable - extract method - guard clause instead of conditional - `present?` instead of regexp
- For Create Observation, include "Leave this field blank if you don't know the scientific name" - else, omit that text
Fixes
```ruby
NameError: undefined local variable or method `form_naming_what_missing' for #<NamingsIntegrationTest:0x00007f2c89cda1d8>
test/integration/capybara/namings_integration_test.rb:51:in `test_proposing_names'
```
7 tasks
- Allows string to change without breaking test - Makes test expectation less magical
nimmolo
reviewed
Jan 13, 2024
| form_observations_there_is_a_problem_with_location: There is a problem with the location. "+See message below.+":#location_messages | ||
| form_observations_there_is_a_problem_with_name: There is a problem with the name. "+See message below.+":#name_messages | ||
| form_observations_there_is_a_problem_with_location: There is a problem with the location. "+[:SEE_MESSAGE_BELOW]+":#location_messages | ||
| form_observations_there_is_a_problem_with_name: There is a problem with the name. "+[:SEE_MESSAGE_BELOW]+":#name_messages | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
"There is a problem with the name. See message below." (with no message below)
displays
"Scientific Name missing"