Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Ruby 3.3.0 #1813

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Retry Ruby 3.3.0 #1813

merged 3 commits into from
Jan 16, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Jan 16, 2024

This time without config.force_ssl. Turns out Unicorn gets an error with that, should be fixed in Unicorn 7.

https://yhbt.net/unicorn-public/new.html

Changing rails' "config.force_ssl" option to "false" makes things to work.

Looking at /usr/local/bundle/gems/unicorn-6.1.0/lib/unicorn/http_response.rb:43, it seems that the cookie header content is a string when force_ssl=false but becomes an array with force_ssl=true

That looks like a Rack 3 response with an array and 6.1.0 doesn't support Rack 3. This patch ought to work:

https://yhbt.net/unicorn-public/ZHlX3HkxP6mK16If@jeremyevans.local/raw

(commit 9d7bab0bc2211b20806d4d0289a7ea992e49a8a1 in unicorn.git)

I'll try to get a unicorn 7.x release soon but tests take forever to run on ancient HW and I need to ration releases to keep download counts low in order to stay under the MFA threshold on Rubygems.org

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.61% (+0.007%) from 94.603%
when pulling a71ecf1 on nimmo-ruby-3.3.0
into d2fa69d on main.

@nimmolo nimmolo merged commit 8d95b22 into main Jan 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants