Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensu lato propagation #1823

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Sensu lato propagation #1823

merged 6 commits into from
Jan 20, 2024

Conversation

JoeCohen
Copy link
Member

  • Does not show a classification propagation link for Names sensu lato.
  • The change prevents potential propogation of an overbroad, imprecise Classification to lower ranks.
  • Fixes Sensu lato propagation #1817

@JoeCohen
Add test exposing presence of undesired link
db39b95 
Includes new Name fixture
@JoeCohen
Make test green
4fe77a2 
- Show classification propagation link only for genera s.s.
- Adds `Name#can_propagate?` and associated tests
@JoeCohen
Prefer name s.s. in search for parent while creating name
0c69c31 
- E.g.. prefers `Coprinus` (without author) to
`Coprinus sensu lato`
when looking for parent of `Coprinus comatus`.
- Fixes a failure caused by adding a Name s.l. in this branch.
@JoeCohen
Tidy Name#find_or_create_name_and_parents
31141e8 
- An easy, simple refactor of something which slowed me down when reading this method.
- Uses guard clause instead of conditional,
turning 5 lines of code into 2.
Doesn't seem like it's worth a separate PR.
@JoeCohen JoeCohen linked an issue Jan 19, 2024 that may be closed by this pull request
Sensu lato propagation #1817
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jan 19, 2024 •
edited
Loading

Coverage Status

coverage: 94.605%. remained the same
when pulling 0691338 on jdc-1817-sensu-lato-propagation
into e976784 on main.

JoeCohen
JoeCohen commented Jan 19, 2024
View reviewed changes
test/models/name_test.rb Outdated Show resolved Hide resolved
@JoeCohen JoeCohen marked this pull request as ready for review January 20, 2024 17:14
@JoeCohen JoeCohen merged commit b6ffcc3 into main Jan 20, 2024
5 checks passed
@JoeCohen JoeCohen deleted the jdc-1817-sensu-lato-propagation branch January 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sensu lato propagation
2 participants
@JoeCohen @coveralls