All Names link #1843
Merged
All Names link #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Proves `Names With Observations` links to names_path (all names), and - All Names does not
- Fixes #1841 - Adds helper for all_names_index_tabs - Adds link to names_path (All Names) unless that's already the query
- Removes unused Tabs::NamesHelper methods - See generally, e.g, Martin _Clean Code_; Fowler, _Tidy First?_. - Turns CI checks completely green, improves Coverage. See https://coveralls.io/builds/65195848/source?filename=app%2Fhelpers%2Ftabs%2Fnames_helper.rb
JoeCohen
commented
Jan 20, 2024
| @@ -101,24 +101,7 @@ def mycobank_basic_search_tab | |||
| { class: tab_id(__method__.to_s), target: :_blank, rel: :noopener }] | |||
| end | |||
|
|
|||
| def name_correct_spelling_tab(name) | |||
JoeCohen
commented
Jan 20, 2024
| end | ||
|
|
||
| def all_names_tab(query) | ||
| return if query&.flavor == :all || query&.flavor&.empty? |
There was a problem hiding this comment.
@nimmolo: Does this make sense? Is the 2nd condition over-cautious?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Nameson the Names With Observation page (fixing Issue Names with Observations "All Names" doesn't work #1841)