Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to conventionally named version tables #1990

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Mar 3, 2024

Turns out the default behavior of the gem is to name the columns like "location_versions", which is what i believe we want.
We've been overriding the default to make them "locations_versions".

This PR removes the overrides and migrates to the default table names.

I think this will break old migrations. I'll need to update them (?!)

@pellaea

This comment was marked as resolved.

@nimmolo

This comment was marked as resolved.

@nimmolo

This comment was marked as resolved.

@pellaea

This comment was marked as resolved.

@nimmolo

This comment was marked as resolved.

@pellaea

This comment was marked as resolved.

@nimmolo

This comment was marked as resolved.

@pellaea

This comment was marked as resolved.

@JoeCohen
Copy link
Member

JoeCohen commented Mar 3, 2024

  1. I'm curious why we're doing this.
  2. Would it make any sense to declare acts_as_versioned bankruptcy and switch to a maintained versioning gem.
    I'm pretty sure we'd have to abandon all the old versions and start from scratch. The last time I looked a this there wasn't a path from acts_as_versioned to a newer gem.
    (I also wonder if acts_as_versioned is thread safe.)

@pellaea
Copy link
Member

pellaea commented Mar 3, 2024 via email

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.421%. remained the same
when pulling 36f4f16 on nimmo-version-tables
into 26dcd40 on main.

@nimmolo nimmolo marked this pull request as ready for review March 4, 2024 01:15
@nimmolo nimmolo merged commit 714c8f3 into main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants