-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to conventionally named version tables #1990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
You're right, Joe. The reason we kept acts_as_versioned alive was because
it was so much work to migrate the old tables to the new ones. Surely
that's important, right? We aren't actually considering removing all
editing changes ever made on the site?
…On Sat, Mar 2, 2024 at 10:41 PM Joseph D. Cohen ***@***.***> wrote:
1. I'm curious why we're doing this.
2. Would it make any sense to declare acts_as_versioned bankruptcy and
switch to a maintained versioning gem.
I'm pretty sure we'd have to abandon all the old versions and start
from scratch. The last time I looked a this there wasn't a path from
acts_as_versioned to a newer gem.
(I also wonder if acts_as_versioned is thread safe.)
—
Reply to this email directly, view it on GitHub
<#1990 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTNNOS4U4TB5ISC7UWOVTYWKLWXAVCNFSM6AAAAABEDSD2BWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGAYDQOJVGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the default behavior of the gem is to name the columns like "location_versions", which is what i believe we want.
We've been overriding the default to make them "locations_versions".
This PR removes the overrides and migrates to the default table names.
I think this will break old migrations. I'll need to update them (?!)