Host jQuery locally #2037
Merged
Host jQuery locally #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to shut up the people who have installed browser extensions blocking jquery and then tell us that the site doesn't work, mysteriously. I'm reluctant to do this because it locks our version of a frequently changing library, and forces us to manually update the library. At a certain point we're going to have to tell people to stop blocking public JS repos, or sorry Charlie. But maybe this is not so bad in this case, because we're aiming to eliminate the jQuery dependency with Bootstrap 5, so maybe it's just for a few months.
JoeCohen
reviewed
Mar 18, 2024
There was a problem hiding this comment.
I'm not knowledgeable enough to add anything meaningful to this.
Does hosting jquery increase the load on our system?
@mo-nathan: Is it a good practice to rely on 3rd party services for core functions?
|
This seems reasonable to me. Technically, yes, it increases the load on our system, but the jQuery file is less than 300K and I expect it would be aggressively cached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to shut up the people who have installed browser extensions blocking jquery and then tell us that our images don't load, mysteriously.
I'm reluctant to do this because it locks our version of a frequently changing library, and forces us to manually update the library. jQuery also will load more slowly from our server than from the CDN — if a user has ever downloaded jQuery from the same CDN, they don't even have to load it at all, it will be in the browser cache.
At a certain point we're going to have to tell people to stop blocking public JS repos, or... sorry, Charlie. But maybe this is not so bad in this case, because we're aiming to eliminate the jQuery dependency with Bootstrap 5. Hopefully it's just for a few months.