Show obs - convert turbo-frame
tags to div
#2038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower-maintenance solution for turbo updates on the show obs page:
We don't have to use
<turbo-frame>
tags for "surgical" updates to the DOM.<div>
with anid
is enough.Switching to
<div>
s also means we don't need any special data attributes on nested<a>
links. That's because links within aturbo-frame
expect a response that replaces theturbo-frame
they are nested within, and not a new page. (#2036) It seems like a gotcha that will confuse future developers.Note: there's a separate existing issue here, and I don't know how or if it's related: #2039
Update: it wasn't related, but this PR fixes the issue. The obs id wasn't getting passed to the re-rendered
new
HR/CN links, so the links didn't work.