Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "admin_mode_path" from a GET to a POST #2049

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Mar 21, 2024

#2048 - Prevent accidentally turning on Admin mode by hovering over the Admin button.

Changes the action from show to create in Admin::SessionController.

@coveralls
Copy link
Collaborator

coveralls commented Mar 21, 2024

Coverage Status

coverage: 94.418%. remained the same
when pulling 945ff02 on 2048-POST-admin-mode
into 723ed91 on main.

@nimmolo nimmolo marked this pull request as ready for review March 21, 2024 08:35
@JoeCohen
Copy link
Member

@nimmolo: Thanks for doing this.

  1. It does work to prevent accidentally entering/leaving admin mode, which is great.
  2. When explicitly entering/leaving admin mode, the page you end up on is sort of random.
    It appears to depend on where your cursor has been. Maybe it's what was last eager loaded.
    Perhaps deal with that in a separate PR?

@nimmolo
Copy link
Contributor Author

nimmolo commented Mar 21, 2024

That's true, huh. I imagine it is the last eager loaded page you end up on, and I can't really imagine how we could override that... this preloading is a new twist.

@nimmolo nimmolo merged commit c6c3908 into main Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants