Adjust script/extract_log to handle non-utf8 sequences. #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this. Given all the monkeys banging on all the keyboards, I can see non-utf8 sequences ending up in the log. I can specifically imagine monkeys with bad intent throwing binary data where it shouldn't go. |
|
:) Yep, I'm not overly concerned.
…On Wed, May 1, 2024 at 8:35 AM Nathan Wilson ***@***.***> wrote:
Thanks for fixing this. Given all the monkeys banging on all the
keyboards, I can see non-utf8 sequences ending up in the log. I can
specifically imagine monkeys with bad intent throwing binary data where it
shouldn't go.
—
Reply to this email directly, view it on GitHub
<#2124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTNNLUS4BIX3WGBBLFJDTZADORPAVCNFSM6AAAAABHBGIGX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGQYDIMJSGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "real" problem is why are there non-utf8 sequences in the log??? But be that as it may, code should never crash, as a general rule, and I can at least fix that...