Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Puma for development server #2127

Merged
merged 1 commit into from
May 3, 2024
Merged

Switch to Puma for development server #2127

merged 1 commit into from
May 3, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented May 3, 2024

This switches dev servers to run Puma instead of Webrick, bringing our dev environment a bit closer to production. @mo-nathan says he uses it at work, and seems smooth.

Puma is also the easiest way to run action cable in dev, but i wanted to merge this separately (ahead of #2107) to catch any potential issues.

Please test by running rails s on this branch. You should get something like this:

=> Booting Puma
=> Rails 7.1.3.2 application starting in development 
=> Run `bin/rails server --help` for more startup options
Puma starting in single mode...
* Puma version: 6.4.2 (ruby 3.3.0-p0) ("The Eagle of Durango")
*  Min threads: 1
*  Max threads: 1
*  Environment: development
*          PID: 85550
* Listening on http://127.0.0.1:3000
* Listening on http://[::1]:3000
* Starting control server on unix:///var/folders/qp/jnsw6x194nsd2fl9g91648240000gn/T/puma-status-1714705883016-85550

Debug should work as currently.

I can't remember if other steps are required, but I don't believe so. I didn't make any changes in my config/database.yml in any case.

@nimmolo nimmolo requested review from JoeCohen and mo-nathan May 3, 2024 03:15
@nimmolo nimmolo marked this pull request as ready for review May 3, 2024 03:15
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.446%. remained the same
when pulling c58e2d7 on nimmo-puma-local
into 5cbb901 on main.

@nimmolo nimmolo merged commit 80f739f into main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants